Re: PG_TEST_EXTRA and meson

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Cc: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Tristan Partin <tristan(at)partin(dot)io>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: PG_TEST_EXTRA and meson
Date: 2024-11-04 12:25:43
Message-ID: 8da830e1-be0e-4cc4-b13a-47f431d6dd9d@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 13/09/2024 13:41, Ashutosh Bapat wrote:
> On Thu, Sep 12, 2024 at 4:28 PM Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
>>>
>>> Once this is done, I think we can mark this CF entry as RFC.
>>
>> Thanks for the changes. I applied all of them in respective patches.
>
> Thanks a lot. PFA the patchset with
>
> 1. Improved comment related to PG_TEST_EXTRA in meson.build. More on
> the improvement in the commit message of patch 0002, which should be
> merged into 0001.
> 2. You have written comprehensive commit messages. I elaborated on
> them a bit. I have left your version in the commit message for
> committer to pick up appropriate one.
>
> Marking the entry as RFC.

Committed with minor changes. I squashed the first two patches, and
rephrased the docs and some comments a little.

Thanks!

--
Heikki Linnakangas
Neon (https://neon.tech)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kirill Reshke 2024-11-04 13:38:28 Re: Useless field ispartitioned in CreateStmtContext
Previous Message Amul Sul 2024-11-04 12:17:27 Re: NOT ENFORCED constraint feature