| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
| Subject: | Re: PATCH: Exclude additional directories in pg_basebackup |
| Date: | 2016-08-18 13:30:32 |
| Message-ID: | 8d768ced-7f16-b690-ec13-f42d47432ada@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 8/17/16 7:56 PM, Michael Paquier wrote:
> On Thu, Aug 18, 2016 at 1:35 AM, Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:
>> I don't remember how pg_snapshot works, but it's probably fine
>> to start with an empty subdir (is it possible to export a snapshot from
>> a prepared transaction?)
>
> From xact.c:
> /*
> * Likewise, don't allow PREPARE after pg_export_snapshot. This could be
> * supported if we added cleanup logic to twophase.c, but for now it
> * doesn't seem worth the trouble.
> */
> if (XactHasExportedSnapshots())
> ereport(ERROR,
> (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> errmsg("cannot PREPARE a transaction that has exported snapshots")));
> So that's fine.
Thank you for tracking that down, Michael.
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-08-18 13:30:58 | Re: Anyone want to update our Windows timezone map? |
| Previous Message | Magnus Hagander | 2016-08-18 13:28:18 | Re: Anyone want to update our Windows timezone map? |