Re: Amcheck verification of GiST and GIN

From: Tomas Vondra <tomas(at)vondra(dot)me>
To: Kirill Reshke <reshkekirill(at)gmail(dot)com>
Cc: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, Alexander Lakhin <exclusion(at)gmail(dot)com>, Andrey Borodin <amborodin86(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Jose Arthur Benetasso Villanova <jose(dot)arthur(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Amcheck verification of GiST and GIN
Date: 2025-03-29 15:54:24
Message-ID: 8c8cc305-325b-4fa5-89f6-b63412bbe0d3@vondra.me
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 3/28/25 20:51, Kirill Reshke wrote:
> On Fri, 28 Mar 2025 at 21:26, Tomas Vondra <tomas(at)vondra(dot)me> wrote:
>>
>> Here's a polished version of the patches. If you have any
>> comments/objections, please speak now.
>> --
>> Tomas Vondra
>
> Hi, no objections, lgtm
>

I've pushed all the parts of this patch series, except for the stress
test - which I think was not meant for commit.

buildfarm seems happy so far, except for a minor indentation issue
(forgot to reindent after merging the separate fix patch).

Marked as committed in the CFA - that's not entirely correct, because
the original patch series also included amcheck support for GiST, but
that was not committed. I suggest we open a new CF entry if that gets
resubmitted for PG19 (I hope that will be the case).

Thanks for the patches, reviews, etc.!

--
Tomas Vondra

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2025-03-29 16:06:53 Re: in BeginCopyTo make materialized view using COPY TO instead of COPY (query).
Previous Message Andres Freund 2025-03-29 15:15:47 Why does wait_for_log() return current file size