Strip -mmacosx-version-min options from plperl build

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Strip -mmacosx-version-min options from plperl build
Date: 2022-08-18 06:57:51
Message-ID: 8c4fcb72-2574-ff7c-4c25-1f032d4a2a57@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

When building on macOS against a Homebrew-provided Perl installation, I
get these warnings during the build:

ld: warning: object file (SPI.o) was built for newer macOS version
(12.4) than being linked (11.3)
ld: warning: object file (plperl.o) was built for newer macOS version
(12.4) than being linked (11.3)
...

This is because the link command uses the option
-mmacosx-version-min=11.3, which comes in from perl_embed_ldflags (perl
-MExtUtils::Embed -e ldopts), but the compile commands don't use that
option, which creates a situation that ld considers inconsistent.

I think an appropriate fix is to strip out the undesired option from
perl_embed_ldflags. We already do that for other options. Proposed
patch attached.

Attachment Content-Type Size
0001-Strip-mmacosx-version-min-options-from-plperl-build.patch text/plain 1.6 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nitin Jadhav 2022-08-18 07:02:31 Re: Skipping schema changes in publication
Previous Message Peter Smith 2022-08-18 06:51:08 Re: Perform streaming logical transactions by background workers and parallel apply