| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | Chapman Flack <chap(at)anastigmatix(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Robert Haas <robertmhaas(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] AdvanceXLInsertBuffer vs. WAL segment compressibility |
| Date: | 2018-03-28 00:09:10 |
| Message-ID: | 8c00b26a-d6da-5764-e67e-9c4d8128081a@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/28/2018 12:32 AM, Chapman Flack wrote:
> On 03/26/18 01:43, Michael Paquier wrote:
>
>> Have a look at BKP_REMOVABLE then. This was moved to page headers in
>> 2dd9322, still it seems to me that the small benefits outlined on this
>> thread don't justify breaking tools relying on this flag set, especially
>> if there is no replacement for it.
>
> Is 2dd9322 a commit? I'm having difficulty finding it:
>
> https://git.postgresql.org/gitweb/?p=postgresql.git&a=search&h=HEAD&st=commit&s=2dd9322
>
> Am I searching wrong?
>
Not sure what's up with gitweb, but git finds it without any issue:
> I probably won't have more time to look at this tonight, but could
> I ask in advance for examples of tools that would need this bit when
> encountering unwritten pages at the end of a segment?
>
> I don't mean that as snark; it's just nonobvious to me and I might need
> a little nudge where to look.
>
> -Chap
>
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2018-03-28 00:11:47 | Re: Changing WAL Header to reduce contention during ReserveXLogInsertLocation() |
| Previous Message | Tomas Vondra | 2018-03-28 00:06:37 | Re: Parallel Aggregates for string_agg and array_agg |