| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, jian he <jian(dot)universality(at)gmail(dot)com> |
| Subject: | Re: Virtual generated columns |
| Date: | 2025-02-07 12:34:47 |
| Message-ID: | 8be3512a-a23f-4088-a9ec-bf68650a2997@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 06.02.25 00:25, Dean Rasheed wrote:
> On Tue, 4 Feb 2025 at 22:36, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>>
>> Yeah, this is quite contorted. I have renamed it like you suggested.
>
> I looked over this again and I think the patch is in good shape to be committed.
I've committed it. Thanks.
> One thought that occurred to me was whether it would be better for the
> psql describe output (and maybe also pg_dump) to explicitly output
> "virtual" for columns of this kind. I know that that's the default for
> generated columns, but someone reading the output might not know or
> remember that, so perhaps it would be helpful to be explicit.
My preference was to have the default output format use only
SQL-standard syntax, not extensions like "VIRTUAL". If people hate
this, we can easily change it.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-02-07 12:36:28 | Re: Virtual generated columns |
| Previous Message | Alexander Korotkov | 2025-02-07 11:39:09 | Re: Get rid of WALBufMappingLock |