| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
| Subject: | Re: Fix optimization of foreign-key on update actions |
| Date: | 2019-03-11 11:57:49 |
| Message-ID: | 8b911478-9c6e-9062-6d2c-654e4bfb570c@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-02-06 23:15, Peter Eisentraut wrote:
> On 05/02/2019 17:20, Tom Lane wrote:
>> What I *don't* like about the proposed patch is that it installs a
>> new, different comparison rule for the ON UPDATE CASCADE case only.
>> If we were to go in this direction, I'd think we should try to use
>> the same comparison rule for all FK row comparisons.
>
> That's easy to change. I had it like that in earlier versions of the
> patch. I agree it would be better for consistency, but it would create
> some cases where we do unnecessary extra work.
Updated patch with this change made, and some conflicts resolved.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Test-case-for-keys-that-look-different-but-compar.patch | text/plain | 2.5 KB |
| v2-0002-Fix-optimization-of-foreign-key-on-update-actions.patch | text/plain | 8.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2019-03-11 11:58:17 | Re: [Patch] Log10 and hyperbolic functions for SQL:2016 compliance |
| Previous Message | Alvaro Herrera | 2019-03-11 11:57:39 | Re: Fix volatile vs. pointer confusion |