Re: Vacuum statistics

From: Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru>
To: Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: jian he <jian(dot)universality(at)gmail(dot)com>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Andrei Zubkov <zubkov(at)moonset(dot)ru>, Alena Rybakina <lena(dot)ribackina(at)yandex(dot)ru>, a(dot)lepikhov(at)postgrespro(dot)ru
Subject: Re: Vacuum statistics
Date: 2024-10-16 11:01:55
Message-ID: 8b2f3c20-02ac-4658-b78f-e9d7590f893b@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi!

On 16.10.2024 13:31, Ilia Evdokimov wrote:
>
>
> On 08.10.2024 19:18, Alena Rybakina wrote:
>> Made a rebase on a fresh master branch.
>> --
>> Regards,
>> Alena Rybakina
>> Postgres Professional
>
> Thank you for rebasing.
>
> I have noticed that when I create a table or an index on this table,
> there is no information about the table or index in
> pg_stat_vacuum_tables and pg_stat_vacuum_indexes until we perform a
> VACUUM.
>
> Example:
>
> CREATE TABLE t (i INT, j INT);
> INSERT INTO t SELECT i/10, i/100 FROM GENERATE_SERIES(1,1000000) i;
> SELECT * FROM pg_stat_vacuum_tables WHERE relname = 't';
> ....
> (0 rows)
> CREATE INDEX ON t (i);
> SELECT * FROM pg_stat_vacuum_indexes WHERE relname = 't_i_idx';
> ...
> (0 rows)
>
> I can see the entries after running VACUUM or executing autovacuum. or
> when autovacuum is executed. I would suggest adding a line about the
> relation even if it has not yet been processed by
> vacuum. Interestingly, this issue does not occur with
> pg_stat_vacuum_database:
>
> CREATE DATABASE example_db;
> SELECT * FROM pg_stat_vacuum_database WHERE dbname = 'example_db';
> dboid |       dbname | ...
>  ...      | example_db | ...
> (1 row)
>
> BTW, I recommend renaming the view pg_stat_vacuum_database to
> pg_stat_vacuum_database_S_  for consistency with pg_stat_vacuum_tables
> and pg_stat_vacuum_indexes
>
Thanks for the review. I'm investigating this. I agree with the
renaming, I will do it in the next version of the patch.

--
Regards,
Alena Rybakina
Postgres Professional

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2024-10-16 11:03:21 Re: Add “FOR UPDATE NOWAIT” lock details to the log.
Previous Message Ilia Evdokimov 2024-10-16 10:31:43 Re: Vacuum statistics