Re: pgsql: Unbreak recovery test on Windows

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, tomas(dot)vondra(at)postgresql(dot)org
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Unbreak recovery test on Windows
Date: 2021-03-21 17:40:12
Message-ID: 8b18dd96-964e-b48c-61b1-ef8888bf0c3b@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


On 3/21/21 1:06 PM, Andrew Dunstan wrote:
> On 3/21/21 12:38 PM, Tom Lane wrote:
>> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>>> Unbreak recovery test on Windows
>> Hmm, looks like this broke things on other machines.
>> crake and sifaka (so far) are showing
>>
>> # Running: pg_ctl kill KILL 2237831
>> ok 3 - killed process with KILL
>> ack Broken pipe: write( 13, '\\q
>> ' ) at /usr/share/perl5/vendor_perl/IPC/Run/IO.pm line 549.
>>
>> which looks like a race condition: did we manage to stuff the "\q"
>> command down the pipe before killing the psql process, or not?
>>
>>
>
> Ugh.  Is there any reason we need to do those kills before we end the
> psql processes? If not I'm tempted just to move them - after the psql's
> are finished it should be safe. At any rate I'll go and test that.
>
>

Well, no good deed goes unpunished. That makes things hang on my Linux
box. Maybe we should just send the \q on Windows.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2021-03-21 17:57:13 pgsql: Fix new memory leaks in libpq
Previous Message Andrew Dunstan 2021-03-21 17:06:46 Re: pgsql: Unbreak recovery test on Windows