Re: RFC: Logging plan of the running query

Hi

I've recently resumed work on this proposal.

I was revising tests that use the injection point, but given that there
was a recent talk at PGConf.EU about further features based on this
proposal [1], I thought it might be of interest to some. Therefore, I'll
share a patch that removes the injection point section for now.

Due to both the lack of an alternative implementation and the following
comment, I’ve taken the approach of wrapping all plan nodes:

On Tue, Mar 26, 2024 at 11:35 AM Andres Freund andres(at)anarazel(dot)de wrote:
>> Andres, did you have some clever idea for this feature that would
>> avoid the need to do this?
> No. I think it's acceptable though.

As a primary change since the last version, I have added wrapping
processing for child nodes other than left/right tree nodes in response
to the feedback in comment [2].

For nodes other than CustomScanState, I have confirmed via DEBUG logs
that the wrap/unwrap code is being executed. However, I'm still somewhat
uncertain whether CustomScanState should be included in this process.

For testing, I ran below queries in three sessions concurrently during
make installcheck and encountered no issues.

=# select pg_log_query_plan(pid) from pg_stat_activity;
=# \watch 0.1

[1]
https://www.postgresql.eu/events/pgconfeu2024/sessions/session/5689-debugging-active-queries-with-mid-flight-instrumented-explain-plans/
[2]
https://www.postgresql.org/message-id/CA%2BTgmoaaEQtuope6za%3D3GSCZ%2BWJFT4DbF5Cnv0QXFmDnZ_PqFw%40mail.gmail.com

Regards,

--
Atsushi Torikoshi
Seconded from NTT DATA GROUP CORPORATION to SRA OSS K.K.