| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Mark Dilger <hornschnorter(at)gmail(dot)com> |
| Subject: | Re: Escape output of pg_amcheck test |
| Date: | 2024-01-14 06:32:05 |
| Message-ID: | 8a4049cd-2987-49e0-b44f-cd9ba031e7dc@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 08.01.24 16:06, Peter Eisentraut wrote:
> On 08.01.24 15:04, Aleksander Alekseev wrote:
>>> [...] so I quickly wrote some (wrong) instrumentation to try to test
>>> your patch.
>>
>> Yep, it confused me too at first.
>>
>> Since the encoding happens right before exit() call, maybe it's worth
>> changing $b in-place in order to make the code slightly more readable
>> for most of us :)
>
> My patch originally had the old-style
>
> my $b_escaped = $b;
> $b_escaped =~ s/.../;
>
> ... sprintf(..., $b_escaped);
>
> but then I learned about the newish /r modifier and thought it was
> cooler. :)
committed
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2024-01-14 10:47:41 | Re: ALTER ROLE documentation improvement |
| Previous Message | vignesh C | 2024-01-14 05:51:58 | Re: Asynchronous execution support for Custom Scan |