RE: xlog loose ends, continued

> >> xlog.c's ReadRecord formerly contained code that would zero
> >> out the rest of the log segment (and delete the next log segment,
> >> if any) upon detecting a missing or corrupted xlog record.
> >> I removed that code because I considered it horribly dangerous
> >> where it was. If there is anything wrong with either the xlog or
> >> pg_control's pointers to it, that code was quite capable of wiping
> >> out all hope of recovery *and* all evidence of what went wrong.
> > ^^^^^^^^^^^^^^^^^^^^^^^^
>
> What I was thinking about in that last paragraph was manual
> analysis and recovery. I don't think it's a good idea for automatic
> system startup to skip over gaps in the log.

But if we'll not try to read after gap then after restart system will
not notice gap and valid records after it and just rewrite log space
with new records. Not much chance for manual analysis - ppl will
not report any problems.

Vadim