RE: SIGTERM -> elog(FATAL) -> proc_exit() is probably a bad idea

From: "Mikheev, Vadim" <vmikheev(at)SECTORBASE(dot)COM>
To: "'Tom Lane'" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: RE: SIGTERM -> elog(FATAL) -> proc_exit() is probably a bad idea
Date: 2001-01-16 17:18:56
Message-ID: 8F4C99C66D04D4118F580090272A7A234D327E@sectorbase1.sectorbase.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> > Note that elog(ERROR/FATAL) is changed to elog(STOP) if Critical
> > SectionCount > 0.
>
> Not in current sources ;-).
>
> Perhaps Vadim will say that I broke his error scheme, but if so it's
> his own fault for not documenting such delicate code at all.

Ok, it's my fault (though I placed NO ELOG(ERROR) comments everywhere
around critical xlog-related sections of code).

> I believe he's out of town this weekend, so let's wait till he gets
> back and then discuss it some more. Perhaps there is a need to
> distinguish xlog-related critical sections from other ones, or
> perhaps not.

Perhaps. For xlog-related code rule is simple - backend must not be
interrupted till changes are logged.

Vadim

Browse pgsql-hackers by date

  From Date Subject
Next Message Mikheev, Vadim 2001-01-16 17:28:45 RE: SIGTERM -> elog(FATAL) -> proc_exit() is probably a bad idea
Previous Message Dave Page 2001-01-16 17:07:36 RE: ODBC Driver int8 Patch