Re: new warning

From: Greg Jaskiewicz <gj(at)pointblue(dot)com(dot)pl>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: new warning
Date: 2011-11-09 18:17:34
Message-ID: 8E6936DD-EA55-4F60-8A71-BC90D9F15292@pointblue.com.pl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 9 Nov 2011, at 16:16, Robert Haas wrote:

> On Wed, Nov 9, 2011 at 11:12 AM, Kevin Grittner
> <Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
>> This commit adds a new warning on my machine:
>>
>> http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=d326d9e8ea1d690cf6d968000efaa5121206d231
>>
>> copy.c: In function *DoCopy*:
>> copy.c:1861:14: warning: *bufferedTuples* may be used uninitialized
>> in this function
>
> Yeah, I was just noticing that. It looks like it's just a case of the
> compiler failing to see that there can't be a problem in real life, so
> I pushed a fix to initialize it to NULL.
>
Yes, but one day someone will add some more code there - and will forget to initialise it to NULL.. Kabboom. ;)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Jaskiewicz 2011-11-09 18:29:12 Re: const correctness
Previous Message Josh Berkus 2011-11-09 18:15:56 Re: 9.1.2 ?