| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Move OpenSSL random under USE_OPENSSL_RANDOM |
| Date: | 2020-11-05 12:59:11 |
| Message-ID: | 8D9C19AD-674D-4FD2-820E-9B429053719E@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 5 Nov 2020, at 13:28, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> It seems to me that this one would become incorrect if compiling with
> OpenSSL but select a random source that requires an initialization, as
> it would enforce only OpenSSL initialization all the time.
Right, how about something like the attached (untested) diff?
> Theoretical point now, of course, because such combination does not
> exist yet in the code.
Not yet, and potentially never will. Given the consequences of a PRNG which
hasn't been properly initialized I think it's ok to be defensive in this
codepath however.
cheers ./daniel
| Attachment | Content-Type | Size |
|---|---|---|
| openssl_random_macros-v3.patch | application/octet-stream | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hou, Zhijie | 2020-11-05 13:02:52 | RE: Parallel copy |
| Previous Message | Magnus Hagander | 2020-11-05 12:56:27 | Re: Move OpenSSL random under USE_OPENSSL_RANDOM |