| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: trivial improvement to system_or_bail |
| Date: | 2021-06-30 15:36:34 |
| Message-ID: | 8AC32042-183D-452B-9B18-AA150BC99621@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 30 Jun 2021, at 17:24, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> When PostgresNode::system_or_bail() fails, it's quite opaque as to what
> is happening. This patch improves things by printing some detail, as
> suggested in Perl's doc for system().
+1 on this from reading the patch.
+ BAIL_OUT("system $_[0] failed: $!\n");
I wonder if we should take more inspiration from the Perl manual and change it
to "failed to execute" to make it clear that the failure was in executing the
program, not from the program itself?
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-06-30 15:45:27 | Re: trivial improvement to system_or_bail |
| Previous Message | Fabien COELHO | 2021-06-30 15:33:24 | Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors |