| From: | Erik Rijkers <er(at)xs4all(dot)nl> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, DUVAL REMI <REMI(dot)DUVAL(at)cheops(dot)fr>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: proposal: schema variables |
| Date: | 2021-01-14 09:24:27 |
| Message-ID: | 89817942c99da01cd5e7850fe418436b@xs4all.nl |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-01-14 07:35, Pavel Stehule wrote:
> [schema-variables-20210114.patch.gz]
Build is fine. My (small) list of tests run OK.
I did notice a few more documentation peculiarities:
'The PostgreSQL has schema variables' should be
'PostgreSQL has schema variables'
A link to the LET command should be added to the 'See Also' of the
CREATE VARIABLE, ALTER VARIABLE, and DROP VARIABLE pages. (After all,
the LET command is the most interesting)
Similarly, an ALTER VARIABLE link should be added to the 'See Also'
section of LET.
Somehow, the sgml in the doc files causes too large spacing in the html,
example:
I copy from the LET html:
'if that is defined. If no explicit'
(6 spaces between 'defined.' and 'If')
Can you have a look? Sorry - I can't find the cause. It occurs on a
few more places in the newly added sgml/html. The unwanted spaces are
visible also in the pdf.
(firefox 78.6.1, debian)
Thanks,
Erik Rijkers
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-01-14 09:35:15 | Re: remove unneeded pstrdup in fetch_table_list |
| Previous Message | Fujii Masao | 2021-01-14 09:15:44 | Re: [bug fix] Fix the size calculation for shmem TOC |