| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows |
| Date: | 2017-11-20 01:30:45 |
| Message-ID: | 8972.1511141445@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2017-11-19 19:49:01 -0500, Tom Lane wrote:
>> TBH, I would just remove those test cases. Even if they were stable
>> across platforms, they don't directly prove anything at all about
>> whether the feature does what it's supposed to.
> I think it might make sense to rewrite the tests so it doesn't output
> any of the sizes, but instead just compares the size of tables with
> different thresholds. That should be fairly reliable.
Hm, what I'd try after a bit of thought is to stuff the same data
into two different tables with different settings chosen to make it
TOAST or not, and then just test the toast tables for zero or nonzero
size. Setting STORAGE = EXTERNAL on the data column to disable
compression would help make things more stable, too.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2017-11-20 07:06:05 | Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows |
| Previous Message | Simon Riggs | 2017-11-20 01:13:56 | Re: pgsql: Parameter toast_tuple_target controls TOAST for new rows |