| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Magnus Hagander <mha(at)sollentuna(dot)net>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] pgxs/windows |
| Date: | 2006-01-19 20:54:21 |
| Message-ID: | 8964.1137704061@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> What about the question of whether $(DESTDIR) belongs there or not?
>> I think we had concluded that PGXS shouldn't ever use $(DESTDIR),
>> because that's only for install-time stuff.
> I considered that a separate issue and didn't explore it, but I think
> you are right that $(DESTDIR) makes no sense so I will remove it.
> Patch attached.
If these are bogus then so are the uses in Makefile.aix and
Makefile.darwin.
I'm a bit bothered by the ones in pgxs.mk, too, although I suspect we
have to leave those there for the benefit of contrib?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | uwcssa | 2006-01-19 20:54:33 | Re: un-vacuum? |
| Previous Message | Andrew Dunstan | 2006-01-19 20:51:13 | Re: [HACKERS] pgxs/windows |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2006-01-19 21:18:12 | Re: Uninstall scripts for contrib |
| Previous Message | Andrew Dunstan | 2006-01-19 20:51:13 | Re: [HACKERS] pgxs/windows |