Re: tests against running server occasionally fail, postgres_fdw & tenk1

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Fujii Masao <fujii(at)postgresql(dot)org>
Subject: Re: tests against running server occasionally fail, postgres_fdw & tenk1
Date: 2023-02-26 23:59:32
Message-ID: 89490.1677455972@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> Not that I understand why that tries to terminate connections, instead of just
> looking at application name.

The test is trying to verify the application name reported by the
"remote" session, which isn't constant, so we can't just do "select
application_name from pg_stat_activity". I agree that terminating the
connection seems like kind of a strange thing to do --- maybe it's to
ensure that we get a new session with the updated application name
for the next test case? If not, maybe we could do "select 1 from
pg_stat_activity where application_name = computed-pattern", but that
has the same problem that a cache flush might have terminated the
remote session.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2023-02-27 00:10:33 Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication
Previous Message Andres Freund 2023-02-26 23:21:04 Re: meson vs make: missing/inconsistent ENV