| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Dave Cramer <pg(at)fastcrypt(dot)com>, Alexey Grishchenko <programmerag(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PL/Python adding support for multi-dimensional arrays |
| Date: | 2016-10-26 08:03:41 |
| Message-ID: | 893c44ec-f8f8-8d1d-749e-e38fd7d427cb@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/24/2016 10:33 PM, Pavel Stehule wrote:
> Hi
>
> 2016-10-14 10:53 GMT+02:00 Heikki Linnakangas <hlinnaka(at)iki(dot)fi>:
>
>> Please review. Are the docs and the error messages now clear enough on
>> this? We'll need a mention in the release notes too, when it's time for
>> that.
>
> The error message is clear.
Ok, great!
> I tested patches - and the regression test is broken (is not actualized)
Ah, fixed.
> There are no new tests for multidimensional array of composites - there is
> only new negative test.
Added one.
Thanks for the review! Committed, with those little fixes, and some
little last-minute comment tweaks.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2016-10-26 08:15:40 | Re: Typo in pgstat.h |
| Previous Message | Tsunakawa, Takayuki | 2016-10-26 07:36:32 | Re: [bug fix] Stats collector is not restarted on the standby |