From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Rachel Heaton <rachelmheaton(at)gmail(dot)com> |
Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, pchampion(at)vmware(dot)com |
Subject: | Re: [PATCH] Print error when libpq-refs-stamp fails |
Date: | 2021-09-28 13:14:04 |
Message-ID: | 893A8F1B-0F23-42B6-BC72-003298885C7A@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 28 Sep 2021, at 00:55, Rachel Heaton <rachelmheaton(at)gmail(dot)com> wrote:
> While developing I got this error and it was difficult to figure out what was going on.
>
> Thanks to Jacob, I was able to learn the context of the failure, so we created this small patch.
I can see that, and I think this patch makes sense even though we don't have
much of a precedent for outputting informational messages from Makefiles.
> The text of the error message, of course, is up for debate, but hopefully this will make it more clear to others.
+ echo 'libpq must not call exit'; exit 1; \
Since it's not actually libpq which calls exit (no such patch would ever be
committed), I think it would be clearer to indicate that a library linked to is
the culprit. How about something like "libpq must not be linked against any
library calling exit"?
--
Daniel Gustafsson https://vmware.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2021-09-28 13:23:07 | Re: PROXY protocol support |
Previous Message | Nitin Jadhav | 2021-09-28 12:07:00 | Re: when the startup process doesn't (logging startup delays) |