Re: MemSet inline for newNode

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: MemSet inline for newNode
Date: 2002-11-10 14:01:06
Message-ID: 8937.1036936866@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> I have applied this patch to inline MemSet for newNode.
> I will make another commit to make more general use of palloc0.

Refresh my memory on why either of these was a good idea?

> This was already discussed on hackers.

And this was not the approach agreed to, IIRC. What you've done has
eliminated the possibility of optimizing away the controlling tests
in MemSet.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Iavor Raytchev 2002-11-10 14:14:15 Re: The database system is in recovery mode
Previous Message Tom Lane 2002-11-10 13:54:37 Re: The database system is in recovery mode

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2002-11-10 19:49:24 Re: pgsql-server/src Makefile.global.in makefiles/ ...
Previous Message Marko Kreen 2002-11-10 13:04:00 pgcrypto/openssl fix