| From: | Manabu Ori <manabu(dot)ori(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Tatsuo Ishii <ishii(at)postgresql(dot)org>, robertmhaas(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: spinlocks on powerpc |
| Date: | 2012-01-01 11:37:32 |
| Message-ID: | 892AF2DE-F6DC-463B-A9D2-87FC8B748E61@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom, thank you for your advise.
On 2012/01/01, at 3:39, Tom Lane wrote:
> What I suggest we should do about this is provide an overridable option
> in pg_config_manual.h, along the lines of
>
> #if defined(__ppc64__) || defined(__powerpc64__)
> #define USE_PPC_LWARX_MUTEX_HINT
> #endif
>
> and then test that symbol in s_lock.h. This will provide an escape
> hatch for anyone who doesn't want the decision tied to 64-bit-ness,
> while still enabling the option automatically for the majority of
> people who could use it.
Fair enough.
I recreated the patch as you advised.
| Attachment | Content-Type | Size |
|---|---|---|
| ppc-TAS_SPIN-20120101.diff | application/octet-stream | 1.6 KB |
| unknown_filename | text/plain | 702 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2012-01-01 12:01:08 | Re: review: CHECK FUNCTION statement |
| Previous Message | Noah Misch | 2012-01-01 00:41:00 | Re: pg_upgrade and relkind filtering |