From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru> |
Cc: | Gilles Darold <gilles(at)migops(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Case expression pushdown |
Date: | 2021-07-26 15:18:29 |
Message-ID: | 89166.1627312709@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru> writes:
> [ 0001-Allow-pushing-CASE-expression-to-foreign-server-v6.patch ]
This doesn't compile cleanly:
deparse.c: In function 'foreign_expr_walker.isra.4':
deparse.c:920:8: warning: 'collation' may be used uninitialized in this function [-Wmaybe-uninitialized]
if (collation != outer_cxt->collation)
^
deparse.c:914:3: warning: 'state' may be used uninitialized in this function [-Wmaybe-uninitialized]
switch (state)
^~~~~~
These uninitialized variables very likely explain the fact that it fails
regression tests, both for me and for the cfbot. Even if this weren't an
outright bug, we don't tolerate code that produces warnings on common
compilers.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Justin Pryzby | 2021-07-26 15:30:23 | Re: when the startup process doesn't (logging startup delays) |
Previous Message | Robert Haas | 2021-07-26 15:02:48 | Re: [bug?] Missed parallel safety checks, and wrong parallel safety |