Re: BUG #14208: Inconsistent code modification - 3

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: petrum(at)gmail(dot)com, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #14208: Inconsistent code modification - 3
Date: 2016-06-30 16:59:07
Message-ID: 8904.1467305947@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2016-06-30 12:51:51 -0400, Tom Lane wrote:
>> But doesn't the code stanza just above this loop pull that spillage
>> back in?

> If so, sure, it pulls changes back in, but only the first
> static const Size max_changes_in_memory = 4096;
> ones. We should never reconstruct a whole large transaction in memory...

OK, so the failure case is not "empty top level transaction", but
"top level transaction small enough to not have spilled", plus a
spilled subtransaction, correct?

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Andres Freund 2016-06-30 17:00:19 Re: BUG #14208: Inconsistent code modification - 3
Previous Message Andres Freund 2016-06-30 16:55:42 Re: BUG #14208: Inconsistent code modification - 3