Re: explain analyze rows=%.0f

From: Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, vignesh C <vignesh21(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: explain analyze rows=%.0f
Date: 2025-01-11 18:21:16
Message-ID: 88e65a15-2b52-4b44-a636-3736ca030b09@tantorlabs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 11.01.2025 17:02, Guillaume Lelarge wrote:
> Le sam. 11 janv. 2025 à 12:10, Ilia Evdokimov
> <ilya(dot)evdokimov(at)tantorlabs(dot)com> a écrit :
>
>
> On 11.01.2025 12:15, Guillaume Lelarge wrote:
>>
>>
>> Thanks for your patch, this looks like a very interesting feature
>> that I'd like to see in a future release.
>>
>> It did a quick run: patch OK, make OK, make install OK, but make
>> check fails quite a lot on partition_prune.sql.
>>
>> I guess it would need some work on partition_prune.sql tests and
>> perhaps also on the docs.
>>
>> Thanks again.
>>
>>
>> --
>> Guillaume.
>
>
> Yes, certainly. I have fixed partition_prune.sql. In the
> documentation example for EXPLAIN ANALYZE where loops is greater
> than one, I updated how 'rows' and 'loops' values are displayed so
> they appear as decimal fractions with two digits after the decimal
> point.
>
> I attached fixed patch.
>
> Any suggestions?
>
>
> Thanks for the updated patch.
>
> "make check" is happy, so no more suggestions, except you should
> register it in the next commitfest.
>
>
> --
> Guillaume.

Done!

https://commitfest.postgresql.org/52/5501/

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-01-11 19:04:13 Re: pgbench error: (setshell) of script 0; execution of meta-command failed
Previous Message Amul Sul 2025-01-11 17:26:32 Re: NOT ENFORCED constraint feature