Re: pgsql: Enable Unix-domain sockets support on Windows

On 2020-06-26 14:21, Amit Kapila wrote:
> On Sat, Mar 28, 2020 at 7:37 PM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>>
>> Enable Unix-domain sockets support on Windows
>>
>
> +
> +/*
> + * Windows headers don't define this structure, but you can define it yourself
> + * to use the functionality.
> + */
> +struct sockaddr_un
> +{
> + unsigned short sun_family;
> + char sun_path[108];
> +};
>
> I was going through this feature and reading about Windows support for
> it. I came across a few links which suggest that this structure is
> defined in <afunix.h>. Is there a reason for not using this via
> afunix.h?
>
> [1] - https://devblogs.microsoft.com/commandline/af_unix-comes-to-windows/
> [2] - https://gist.github.com/NZSmartie/079d8f894ee94f3035306cb23d49addc

If we did it that way we'd have to write some kind of configuration-time
check for the MSVC build, since not all Windows versions have that
header. Also, not all versions of MinGW have that header (possibly
none). So the current implementation is probably the most practical
compromise.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services