Re: Wrong buffer limits check

> On 29 Jan 2024, at 14:37, Mikhail Gribkov <youzhick(at)gmail(dot)com> wrote:

> I have tried to analyse Postgres code with Svace static analyzer [1] and found something I think is a real bug.
>
> In pgp-decrypt.c, in prefix_init function the following check:
> if (len > sizeof(tmpbuf))
>
> seem to be erroneous and should really look this way:
> if (len > PGP_MAX_BLOCK)

Studying the code I think you're right, we should be ensuring that the cipher
block size isn't exceeding PGP_MAX_BLOCK. In practice it seems night
impossible to hit given the ciphers in cipher_list, but we should still fix it.
Unsurprisingly this seems to have been there forever (since July 2005) so needs
to be backpatched to all supported branches for the sake of consistency

--
Daniel Gustafsson