Re: pgsql: Recalculate search_path after ALTER ROLE.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: Jeff Davis <jdavis(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Recalculate search_path after ALTER ROLE.
Date: 2023-08-10 11:03:52
Message-ID: 88825.1691665432@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Jeff Davis <pgsql(at)j-davis(dot)com> writes:
> On Wed, 2023-08-09 at 16:12 -0700, Jeff Davis wrote:
>> I'm not sure yet, but this looks like a possible pre-existing bug, or
>> some incorrect assumption I made in fa2e874946.

> Before my commit the behavior is the same. Here's a minimal repro
> ...
> Given that it works fine without parallel query, I'm inclined to call
> this a parallel query bug. The error is coming from RestoreGUCState().

Check. Seems like we need a way to restore the role GUC without
performing a catalog lookup. I'll bet there are comparable bugs
with search path, temp tablespace names, etc.

> That being said, the buildfarm is red after my commit, so unless
> someone sees a quick fix here, perhaps I should remove my isolation
> test? I don't want to revert my whole commit, because it seems correct
> and fixes a separate bug.

Yes, just remove the test case for now. It might or might not be
worth the trouble to put it back later.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message John Naylor 2023-08-10 11:43:09 pgsql: Update Solution.pm for new LoongArch CRC symbol
Previous Message Alvaro Herrera 2023-08-10 10:06:54 Re: pgsql: Ignore BRIN indexes when checking for HOT udpates