Re: BTScanOpaqueData size slows down tests

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org, Peter Geoghegan <pg(at)bowt(dot)ie>
Subject: Re: BTScanOpaqueData size slows down tests
Date: 2025-04-02 16:02:02
Message-ID: 886028.1743609722@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> I'm a bit confused by the "MUST BE LAST" comment:
> BTScanPosItem items[MaxTIDsPerBTreePage]; /* MUST BE LAST */

Yeah, me too. It looks like it might've been intended to allow
the items[] array to be only partially allocated. But as Peter
says, we don't do that. Too long ago to be sure :=(

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2025-04-02 16:05:59 Re: index prefetching
Previous Message Peter Geoghegan 2025-04-02 16:01:57 Re: BTScanOpaqueData size slows down tests