From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Jerry Sievers <gsievers19(at)comcast(dot)net>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: SegFault on 9.6.14 |
Date: | 2019-07-31 04:30:46 |
Message-ID: | 885.1564547446@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> On Wed, Jul 31, 2019 at 12:05 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> The other option is to do
>> what I understand Amit and Thomas to be proposing, which is to do a
>> better job identifying the case where we're "done for good" and can
>> trigger the shutdown fearlessly.
> Yes, this sounds safe fix for back-branches.
Actually, my point was exactly that I *didn't* think that would be a
safe fix for the back branches --- at least, not unless you're okay
with a very conservative and hence resource-leaky method for deciding
when it's safe to shut down sub-nodes.
We could do something involving (probably) adding new eflags bits to
pass this sort of info down to child plan nodes. But that's going
to require design and coding, and it will not be backwards compatible.
At least not from the point of view of any extension that's doing
anything in that area.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Ning Yu | 2019-07-31 04:35:02 | Re: Possible race condition in pg_mkdir_p()? |
Previous Message | Ning Yu | 2019-07-31 04:26:30 | Re: Possible race condition in pg_mkdir_p()? |