| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Subject: | Re: [HACKERS] taking stdbool.h into use |
| Date: | 2018-03-21 11:48:02 |
| Message-ID: | 884e8b75-5550-7b9e-1a6f-cd1c268fdfe1@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/21/18 01:51, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
>> On March 20, 2018 8:24:41 PM PDT, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>>> Yeah, I agree with that. Just not using stdbool.h in those cases ought
>>> to be fine. Any platforms where sizeof(bool) is 4 involves macos older
>>> than 10.5 and Windows platforms using MSVC versions older than 2003
>>> (didn't look further down either).
>
>> Aren't there some somewhat modern architectures where that's still the case, for performance reasons? PPC or such?
>
> Well, hydra (F16 on ppc64) has sizeof(bool) = 1. Don't have any other
> good datapoints handy. Presumably we'd set up configure to report
> what it found out, so it wouldn't take long to survey the buildfarm.
I've pushed the configure tests. Let's see what they say.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeevan Chalke | 2018-03-21 12:01:28 | Re: [HACKERS] Partition-wise aggregation/grouping |
| Previous Message | Alexander Korotkov | 2018-03-21 11:32:38 | Re: [HACKERS] [PATCH] Incremental sort |