| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Erik Wienhold <ewie(at)ewie(dot)name>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Underscore in positional parameters? |
| Date: | 2024-05-15 11:59:36 |
| Message-ID: | 883585f9-e75c-440a-8b67-6ff31b1e993a@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 14.05.24 18:07, Erik Wienhold wrote:
> Patch 0001 changes rules param and param_junk to only accept digits 0-9.
I have committed this patch to PG16 and master.
I was a little bit on the fence about what the behavior should be, but I
checked Perl for comparison:
print 1000; # ok
print 1_000; # ok
print $1000; # ok
print $1_000; # error
So this seems alright.
> Patch 0002 replaces atol with pg_strtoint32_safe in the backend parser
> and strtoint in ECPG. This fixes overflows like:
Seems like a good idea, but as was said, this is an older issue, so
let's look at that separately.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marcos Pegoraro | 2024-05-15 12:04:36 | </replaceable> in parentesis is not usual on DOCs |
| Previous Message | Nazir Bilal Yavuz | 2024-05-15 11:28:06 | Re: Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs |