Re: [PATCHES] Implemented current_query

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Tomas Doran <bobtfish(at)bobtfish(dot)net>, Neil Conway <neilc(at)samurai(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] Implemented current_query
Date: 2008-03-29 16:19:53
Message-ID: 8823.1206807593@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Uh, I think based on other usage it should be called client_statement().

That is *exactly* the wrong thing, because "statement" specifically
means one SQL statement.

"client_query" seems about the best compromise I've heard so far.

It's too bad we didn't have this debate before pg_stat_activity got out
into the wild, because it's now too late to rename its column
current_query. Possibly we should stick with current_query() just
for consistency with that view ...

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2008-03-29 17:14:36 Re: [PATCHES] Auto-explain patch
Previous Message Andrew Dunstan 2008-03-29 13:18:22 Re: [DOCS] pg_total_relation_size() and CHECKPOINT

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2008-03-29 16:35:36 Re: create language ... if not exists
Previous Message Andrew Dunstan 2008-03-29 13:18:22 Re: [DOCS] pg_total_relation_size() and CHECKPOINT