Re: New function normal_rand_array function to contrib/tablefunc.

Japin Li <japinli(at)hotmail(dot)com> writes:

> Thanks for updating the patch. Here are some comments.
>
> + if (minlen >= maxlen)
> + ereport(ERROR,
> + (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
> + errmsg("minlen must be greater than maxlen.")));
>
> There error message should be "minlen must be smaller than maxlen", right?
>
> + if (minlen < 0)
> + ereport(ERROR,
> + (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
> + errmsg("minlen and maxlen must be greater than zero.")));
>
> Here the minlen might be zero, so the error message is incorrect.
> How about use "minlen must be greater than or equal to zero"?

Yes, you are right. A new version is attached, thanks for checking!

--
Best Regards
Andy Fan