From: | Alex Shulgin <ash(at)commandprompt(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Dag-Erling Smørgrav <des(at)des(dot)no>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] add ssl_protocols configuration option |
Date: | 2014-12-15 14:15:56 |
Message-ID: | 87y4q9xalf.fsf@commandprompt.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>>>
>>> Perhaps ssloptions.[ch], unless you plan to add non-option-related code
>>> there later?
>>
>> I don't think anything else than common options-related code fits in
>> there, so ssloptions.c makes sense to me.
>>
>>> BTW, there is no Regent code in your openssl.c, so the copyright
>>> statement is incorrect.
>>
>> Good catch, I just blindly copied that from some other file.
> There have been arguments in favor and against this patch... But
> marking it as returned with feedback because of a lack of activity in
> the last couple of weeks. Feel free to update if you think that's not
> correct, and please move this patch to commit fest 2014-12.
Attached is a new version that addresses the earlier feedback: renamed
the added *.[ch] files and removed incorrect copyright line.
I'm moving this to the current CF.
--
Alex
Attachment | Content-Type | Size |
---|---|---|
ssl-protocols-v3.diff | text/x-diff | 20.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2014-12-15 14:29:41 | Re: Custom timestamp format in logs |
Previous Message | Heikki Linnakangas | 2014-12-15 13:58:39 | Re: Commit fest 2014-12, let's begin! |