Re: Fixing parallel make of libpq

From: ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker )
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fixing parallel make of libpq
Date: 2020-01-09 11:03:23
Message-ID: 87y2ugzybo.fsf@wibble.ilmari.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:

> On Wed, Jan 08, 2020 at 01:33:13PM +0000, Dagfinn Ilmari Mannsåker wrote:
>> I noticed to my annoyance that 'make -j4 -C src/interfaces/libpq'
>> doesn't work in a clean checkout, because it can't find
>> libpgcommon_shlib and libpgport_shlib. It looks like that's because the
>> submake-libpgport dependency is declared on the all-lib target, not on
>> the shlib itself. Moving it to SHLIB_PREREQS instead fixes it, patch
>> for which is attached.
>
> Hmm. That logically makes sense. Isn't that a side effect of 7143b3e
> then? Now, FWIW, I am not able to reproduce it here, after trying on
> two different machines, various parallel job numbers (up to 32), and a
> couple of dozen attempts. Perhaps somebody else can see the failures?

It fails reliably for me on Debian Buster, with make 4.2.1-1.2and -j4.
The command to reproduce it is:

git clean -xfd && ./configure && make -Otarget -j4 -C src/interfaces/libpq/

Attached is the output of the `make` step with and without the patch.

- ilmari
--
- Twitter seems more influential [than blogs] in the 'gets reported in
the mainstream press' sense at least. - Matt McLeod
- That'd be because the content of a tweet is easier to condense down
to a mainstream media article. - Calle Dybedahl

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mahendra Singh Thalor 2020-01-09 11:11:43 Re: Questions/Observations related to Gist vacuum
Previous Message Alexandra Wang 2020-01-09 10:57:52 Re: base backup client as auxiliary backend process