From: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
---|---|
To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andreas Karlsson <andreas(at)proxel(dot)se>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
Subject: | Re: Convert sepgsql tests to TAP |
Date: | 2025-01-28 13:34:36 |
Message-ID: | 87y0yv2har.fsf@wibble.ilmari.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> On 27.08.24 10:12, Peter Eisentraut wrote:
>> Here is a new patch version.
>> I simplified the uses of sed and awk inside the Perl script. I also
>> fixed "make installcheck". I noticed that meson installs sepgsql.sql
>> into the wrong directory, so that's fixed also. (Many of the
>> complications in this patch set are because sepgsql is not an
>> extension but a loose SQL script, of which it is now the only one.
>> Maybe something to address separately.)
>> I did end up deciding to keep the old test_sepgsql script, because it
>> does have the documented purpose of testing existing installations. I
>> did change it so that it calls pg_regress directly, without going via
>> make, so that the dependency on make is removed.
>
> This has been committed. And I understand there is a buildfarm client
> update available for the affected buildfarm members.
This patch passed the TAP command invocation cleanup patch mid-flight,
so didn't get the memo about command usng the fat comma for line option
arguments. Here's a patch for bringing it in line with the new
convention. I don't have any machines with SELinux enabled, so either
someone who has would need to test it, or we can rely on the buildfarm.
- ilmari
Attachment | Content-Type | Size |
---|---|---|
0001-sepgsql-update-TAP-test-to-use-fat-comma-style.patch | text/x-diff | 1.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2025-01-28 14:01:58 | Re: Windows CFBot is broken because ecpg dec_test.c error |
Previous Message | Daniel Gustafsson | 2025-01-28 12:13:52 | Re: Feature Request: Add AES-128-CFB Mode Support to pgcrypto |