From: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Japin Li <japinli(at)hotmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: test_escape: invalid option -- 'c' |
Date: | 2025-02-18 13:11:11 |
Message-ID: | 87y0y31jps.fsf@wibble.ilmari.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Tue, Feb 18, 2025 at 11:12:13AM +0800, Japin Li wrote:
>> When I test test_escape, I find the usage of test_escape declares it
>> support -c option, however, when I use it, it complains it is an
>> invalid option.
>>
>> Here is a patch to fix it.
>
> You are right, obviously. The only reason why this is not showing up
> is that the TAP test uses the long option --conninfo.
This was something I did consider when porting the tests to use long
options: should we leave (or add) at least one usage of every
corresponding shor option, for exactly this reason?
> Speaking of which, this had better use fat commas to combine the
> option/value pairs in these commands.
I have a local branch which converts more of the tests to the long and
fat style, I'll try to finish that up for submission soon, and look at
adding/retaining coverage for short options.
- ilmari
From | Date | Subject | |
---|---|---|---|
Next Message | Richard Guo | 2025-02-18 13:12:31 | Re: Virtual generated columns |
Previous Message | Rahila Syed | 2025-02-18 13:05:38 | Re: Enhancing Memory Context Statistics Reporting |