From: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Melanie Plageman <melanieplageman(at)gmail(dot)com> |
Subject: | Re: Making background psql nicer to use in tap tests |
Date: | 2023-03-17 18:07:40 |
Message-ID: | 87v8izs13n.fsf@wibble.ilmari.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 2023-03-17 Fr 10:08, Daniel Gustafsson wrote:
>>> Why is $restart_before_query a package/class level value instead of
>>> an instance value? And why can we only ever set it to 1 but not back
>>> again? Maybe we don't want to, but it looks odd.
>> It was mostly a POC to show what I meant with the functionality. I think there
>> should be a way to turn it off (set it to zero) even though I doubt it will be
>> used much.
>
>
> A common idiom is to have a composite getter/setter method for object
> properties something like this
>
>
> sub settingname
> {
> my ($self, $arg) = @_;
> $self->{settingname} = $arg if defined $arg;
> return $self->{settingname};
> }
Or, if undef is a valid value:
sub settingname
{
my $self = shift;
$self->[settingname} = shift if @_;
return $self->{settingname};
}
- ilmari
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Davis | 2023-03-17 18:10:13 | Re: ICU 54 and earlier are too dangerous |
Previous Message | Jeff Davis | 2023-03-17 17:55:56 | Re: ICU locale validation / canonicalization |