| From: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Greg Nancarrow <gregn4422(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Fetter <david(at)fetter(dot)org>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Slim down integer formatting |
| Date: | 2021-07-27 05:07:52 |
| Message-ID: | 87tukgfj5v.fsf@news-spur.riddles.org.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>>>>> "David" == David Rowley <dgrowleyml(at)gmail(dot)com> writes:
David> I think the mistake is that the header file is not in
David> src/include/common. For some reason, it's ended up with all the
David> .c files in src/common.
David> I imagine Andrew did this because he didn't ever expect anything
David> else to have a use for these. He indicates that in [1].
David> Maybe Andrew can confirm?
It's not that anything else wouldn't have a use for those, it's that
anything else SHOULDN'T have a use for those because they are straight
imports from upstream Ryu code, they aren't guaranteed to work outside
the ranges of values required by Ryu, and if we decided to import a
newer copy of Ryu then it would be annoying if any other code was broken
as a result.
In short, please don't include d2s_intrinsics.h from anywhere other than
d2s.c
--
Andrew.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-07-27 05:14:14 | Re: [bug?] Missed parallel safety checks, and wrong parallel safety |
| Previous Message | Fabien COELHO | 2021-07-27 04:36:15 | Re: Some code cleanup for pgbench and pg_verifybackup |