Re: improve routine vacuuming docs

From: Neil Conway <neilc(at)samurai(dot)com>
To: Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: improve routine vacuuming docs
Date: 2003-12-11 17:34:53
Message-ID: 87smjrqmv6.fsf@mailbox.samurai.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Robert Treat <xzilla(at)users(dot)sourceforge(dot)net> writes:
> Should be "TRUNCATE removes the <emphasis>entire</emphasis> content of
> the table immediately, without requiring a subsequent
> <command>VACUUM</command> or <command>VACUUM FULL</command> to
> reclaim the now-unused disk space."

I think the <emphasis/> is overkill, but otherwise I've made this
change.

> Maybe better is ..."risk of OID wraparound failures".

Why? XID wraparound and OID wraparound are completely distinct
issues. I think from the context it's pretty clear that XID wraparound
is what is being referred to here.

> What differentiates the first SELECT as a command and the second
> SELECT as a literal? Some question for CASE really...

Well, the rule-of-thumb is that SQL commands are marked with
<command/>, but clauses of commands or entire example queries are
marked with <literal/>. I think the <literal>CASE</> is correct, but
on closer examination, the second SELECT should probably also be
marked with <command/>.

I've attached a revised patch that incorporates these changes. Thanks
for the feedback!

-Neil

Attachment Content-Type Size
routine-vacuum-doc-3.patch text/x-patch 31.6 KB

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message veramente@libero.it 2003-12-11 19:13:55 psql-current italian translation updates
Previous Message Neil Conway 2003-12-11 05:30:41 improve routine vacuuming docs