| From: | Gregory Stark <stark(at)enterprisedb(dot)com> |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Zoltan Boszormenyi" <zb(at)cybertec(dot)at>, <pgsql-patches(at)postgresql(dot)org>, "Hans-Juergen Schoenig" <hs(at)cybertec(dot)at>, "Magnus Hagander" <magnus(at)hagander(dot)net> |
| Subject: | Re: float4/float8/int64 passed by value with tsearchfixup |
| Date: | 2008-04-20 12:32:59 |
| Message-ID: | 87skxg905g.fsf@oxford.xeocode.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> BTW, I trolled the contrib files for other v0 functions taking or
> returning float4 or float8. I found seg_size (fixed it) and a whole
> bunch of functions in earthdistance. Those use float8 not float4,
> so they are not broken by this patch, but that module will have to
> be v1-ified before we can consider applying the other part of the
> patch.
So are you killing V0 for non-integral types? Because if not we should keep
some sacrificial module to the regression tests to use to test for this
problem.
I don't see any way not to kill v0 for non-integral types if we want to make
float4 and float8 pass-by-value. We could leave those pass-by-reference and
just make bigint pass-by-value.
--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Ask me about EnterpriseDB's On-Demand Production Tuning
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zoltan Boszormenyi | 2008-04-20 14:54:28 | Re: float4/float8/int64 passed by value with tsearchfixup |
| Previous Message | Gregory Stark | 2008-04-20 09:23:33 | Re: float4/float8/int64 passed by value with tsearchfixup |