Re: Bug fix for glibc broke freebsd build in REL_11_STABLE

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Victor Wagner <vitus(at)wagner(dot)pp(dot)ru>
Subject: Re: Bug fix for glibc broke freebsd build in REL_11_STABLE
Date: 2018-09-04 16:38:50
Message-ID: 87r2i9usvs.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>>>>> "Andres" == Andres Freund <andres(at)anarazel(dot)de> writes:

>> However, this commit broke float8 test on 32-bit FreeBSD 11 with
>> clang 3.8.0 compiler. Regressions.diff follows:

Andres> Does this happen with a newer clang version too?

float8 test (and all other tests) passes for me on clang 3.9.1 on fbsd11
on 32-bit ARM, and on -m32 builds on amd64.

I also confirmed that without #define isinf(x) __builtin_isinf(x), on
both 32bit and 64bit fbsd isinf() compiles as a function call, so the
OP's proposed change would not be desirable.

--
Andrew (irc:RhodiumToad)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-09-04 16:42:40 Re: PostgreSQL logical decoder output plugin - unchanged toast data
Previous Message Bossart, Nathan 2018-09-04 15:49:09 Re: Add SKIP LOCKED to VACUUM and ANALYZE