From: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
Subject: | Re: Using POPCNT and other advanced bit manipulation instructions |
Date: | 2019-02-13 20:09:01 |
Message-ID: | 87r2cbo4c3.fsf@news-spur.riddles.org.uk |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>>>>> "Andres" == Andres Freund <andres(at)anarazel(dot)de> writes:
>> It's likely to be hard to tell, given the amount of pink from the
>> Ryu patch. If Andrew is not planning to clean that up PDQ,
Besides crake (x-version), fulmar (icc) and lorikeet (cygwin), I hope
the rest of the known failures should pass on the next cycle; the
mac/ppc failures are because we redefine "bool" in a way that broke the
upstream code's c99 assumptions, and the rest are numerical instability
in ts_rank.
>> I'd suggest reverting that patch pending having some repairs for it.
Andres> I'd assume that breaking bit counting would cause distinct
Andres> enough damage (compile time or crashes). That's not to say that
Andres> reverting ryu shouldn't be considered (although I'm not that
Andres> bothered by cross version, ia64 and cygwin failures, especially
Andres> because the latter two might be hard to come by outside the
Andres> bf).
IA64 is working fine as far as I can see (specifically, anole is
passing); it's ICC on x86_64 that broke (fulmar).
--
Andrew (irc:RhodiumToad)
From | Date | Subject | |
---|---|---|---|
Next Message | David Steele | 2019-02-13 20:10:16 | Re: Commit Fest 2019-01 is now closed |
Previous Message | Tom Lane | 2019-02-13 19:49:28 | Re: Using POPCNT and other advanced bit manipulation instructions |