Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1

From: Gregory Stark <stark(at)enterprisedb(dot)com>
To: "Zoltan Boszormenyi" <zb(at)cybertec(dot)at>
Cc: <pgsql-patches(at)postgresql(dot)org>, "Hans-Juergen Schoenig" <hs(at)cybertec(dot)at>
Subject: Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1
Date: 2008-03-24 23:01:34
Message-ID: 87prtjohf5.fsf@oxford.xeocode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

"Zoltan Boszormenyi" <zb(at)cybertec(dot)at> writes:

> - the int8inc(), int2_sum() and int4_sum() used pointers directly from the
> Datums
> for performance, that code path is now commented out, the other code path
> is correct for the AggState and !AggState runs and correct every time and now
> because of the passbyval nature of int8, the !AggState version is not slower
> than using the pointer directly.

Does this mean count() and sum() are slower on a 32-bit machine?

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Get trained by Bruce Momjian - ask me about EnterpriseDB's PostgreSQL training!

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Zoltan Boszormenyi 2008-03-24 23:15:05 Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1
Previous Message Joshua D. Drake 2008-03-24 22:38:16 Re: script binaries renaming