From: | Andy Fan <zhihuifan1213(at)163(dot)com> |
---|---|
To: | Andy Fan <zhihuifan1213(at)163(dot)com> |
Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: using extended statistics to improve join estimates |
Date: | 2024-04-28 01:43:42 |
Message-ID: | 87pluajl5c.fsf@163.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello Tomas!
>>> At for the code level, I reviewed them in the top-down manner and almost
>>> 40% completed. Here are some findings just FYI. For efficiency purpose,
>>> I provide each feedback with a individual commit, after all I want to
>>> make sure my comment is practical and coding and testing is a good way
>>> to archive that. I tried to make each of them as small as possible so
>>> that you can reject or accept them convinently.
>>>
>>> 0001 is your patch, I just rebase them against the current master. 0006
>>> is not much relevant with current patch, and I think it can be committed
>>> individually if you are OK with that.
>>>
>>> Hope this kind of review is helpful.
>>>
>>
>> Cool! There's obviously no chance to get this into v18, and I have stuff
>> to do in this CF. But I'll take a look after that.
>
> Good to know that. I will continue my work before that.
I have completed my code level review and modification. These individual
commits and message probably be helpful for discussion.
--
Best Regards
Andy Fan
Attachment | Content-Type | Size |
---|---|---|
ext_stats_on_join.tar | application/x-tar | 170.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andy Fan | 2024-04-28 02:07:01 | Re: using extended statistics to improve join estimates |
Previous Message | Andrei Lepikhov | 2024-04-28 01:22:30 | Re: query_id, pg_stat_activity, extended query protocol |