Re: 8.3.3 compiler warnings with gcc 4.3

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

> Devrim =?ISO-8859-1?Q?G=DCND=DCZ?= <devrim(at)gunduz(dot)org> writes:
>> I'm getting these on Fedora-9:
>> tqual.c:115: warning: inlining failed in call to ‘SetHintBits’: call is
>
> They're just cosmetic. We don't generally worry about fixing cosmetic
> warnings in back branches.

Are they? It seems like these were marked inline for a reason. SetHintBits has
at least one conditional in it which can often be optimized out (it's either
InvalidTransactionId or else has been tested already).

In the tuplestore case there's not much point in having that function if it's
not going to be inlined. I'm imagining that it was put in because someone did
verify that the non-inlined version was consuming significant time. -- Perhaps
a bit assumption though.

Also, is 8.3 really a "back branch"? It's the current release and anyone
downloading Postgres from source on the web site will be getting these
warnings -- and there are a lot of them. Enough that it looks like something's
gone wrong with the build.

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Ask me about EnterpriseDB's RemoteDBA services!