Re: [sqlsmith] Crash on GUC serialization

From: Andreas Seltenreich <seltenreich(at)gmx(dot)de>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [sqlsmith] Crash on GUC serialization
Date: 2016-11-19 17:51:52
Message-ID: 87oa1b73yf.fsf@credativ.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier writes:

> [2. text/plain; fix-guc-string-eval.patch]

I'm afraid taking care of the length computation is not sufficient.
ISTM like it'll still try to serialize the NULL pointer later on in
serialize_variable:

,----[ guc.c:9108 ]
| case PGC_STRING:
| {
| struct config_string *conf = (struct config_string *) gconf;
| do_serialize(destptr, maxbytes, "%s", *conf->variable);
`----

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gilles Darold 2016-11-19 17:59:49 Re: Patch to implement pg_current_logfile() function
Previous Message Michael Paquier 2016-11-19 17:44:23 Re: [sqlsmith] Crash on GUC serialization